Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation test for Issue 48660 and Issue 48508 #1833

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

labkey-sweta
Copy link
Contributor

Rationale

Regression coverage for Secure Issue 48508: SaveSourceQueryAction doesn't check for JavaScript in XML payload and Secure Issue 48660: SaveSourceQueryAction doesn't check for JavaScriptDisplayColumnFactory

Related Pull Requests

Changes

New test class : src/org/labkey/test/tests/PermissionsTestForJavascriptExecution.java

@labkey-sweta labkey-sweta requested review from labkey-jeckels, a team and labkey-chrisj and removed request for a team February 22, 2024 15:54
@labkey-sweta labkey-sweta self-assigned this Feb 22, 2024
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion for code cleanup

@labkey-sweta labkey-sweta merged commit 6baf5a3 into release23.11-SNAPSHOT Feb 23, 2024
3 of 4 checks passed
@labkey-sweta labkey-sweta deleted the 23.11_fb_48508AutoTest branch February 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants