don't call searchIndexer unless search module is present #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Recently in #1826 I added a call to
SearchAdminAPIHelper.waitForIndexerBackground()toBaseWebDriverTest.WaitForPendingRequests(which is called before cleaning up tests), with the intention of preventing intermittent failures that can arise when the indexer is indexing something when it is being deleted.Unfortunately, this caused failures in tests that don't have the Search module (🤦doh)
This change checks beforehand to see if
_containerHelper.getAllModules.contains("Search")and only asks the indexer to wait if the Search module is presentRelated Pull Requests
#1826
Changes
Only ask search indexer to wait if search module is there