Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selenium #1815

Merged
merged 15 commits into from
Mar 15, 2024
Merged

Update Selenium #1815

merged 15 commits into from
Mar 15, 2024

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Feb 1, 2024

Rationale

We are several selenium versions behind. Better to update now than to wait until it become urgent.
There were some errors on TeamCity that required a refactor of how tests start new browser instances for fetching the list of server-side unit tests. Fixing that led to refactoring some login helpers and the artifact collector.

Related Pull Requests

  • N/A

Changes

  • Update Selenium
  • Create ApiBootstrapHelper to be shared by JUnitTest and QuickBootstrapPseudoTest
  • Update ArtifactCollector to not require a test object
  • Move heap dump method to BaseWebDriverTest

@labkey-tchad labkey-tchad linked an issue Feb 1, 2024 that may be closed by this pull request
@labkey-tchad labkey-tchad marked this pull request as ready for review March 13, 2024 23:39
Copy link
Contributor

@labkey-danield labkey-danield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. I did see these failures in LKB & LKSM. Are they related to this change?

@labkey-tchad
Copy link
Member Author

This looks ok to me. I did see these failures in LKB & LKSM. Are they related to this change?

Yup. I'll have to get that fixed before merging.

@labkey-tchad labkey-tchad merged commit a05f123 into develop Mar 15, 2024
2 checks passed
@labkey-tchad labkey-tchad deleted the fb_selenium416 branch March 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LabKey CI] Upgrade Selenium
2 participants