Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvements for checking CSP log #1768

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Test improvements for checking CSP log #1768

merged 1 commit into from
Dec 28, 2023

Conversation

labkey-tchad
Copy link
Member

Rationale

Running the CSP checker more has revealed some areas for improvement.

Related Pull Requests

Changes

  • Add crawlertest-cspWarning to test CSP warning detection
  • Make the useEmbeddedTomcat flag propagate to tests running in IntelliJ
  • Run the CSP check after the crawler
  • Add method to ignore expected CSP errors
  • Add webtest.cspCheck flag to test.properties.template

@labkey-tchad labkey-tchad requested review from labkey-matthewb, a team and labkey-danield and removed request for a team December 21, 2023 23:59
@labkey-tchad labkey-tchad merged commit 0a6768d into develop Dec 28, 2023
1 check passed
@labkey-tchad labkey-tchad deleted the fb_cspCheckValidation branch December 28, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-danield labkey-danield labkey-danield approved these changes

@labkey-matthewb labkey-matthewb Awaiting requested review from labkey-matthewb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-tchad @labkey-danield