Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint issues in variations.js #26

Closed
wants to merge 20 commits into from
Closed

eslint issues in variations.js #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b632928
@purejerome says to put this in eslint
hcientist Jul 4, 2024
550f369
let's configure the project to use the eslint for the formatter and t…
hcientist Jul 4, 2024
e766dbc
update prettier version, require eslint plugin
hcientist Jul 5, 2024
aa43048
test standardizing format on a single file: api.js
hcientist Jul 5, 2024
5b49450
eslint and prettier disagree about indentation, let prettier win bc w…
hcientist Jul 5, 2024
7c6c307
with these changes, top-level .js files all pass eslint with no warni…
hcientist Jul 5, 2024
cad351e
with these changes, top-level pages pass linter
hcientist Jul 5, 2024
eadbf17
whoops this extension cannot format jsx.
hcientist Jul 5, 2024
c05ebeb
with these changes, all pages pass linter
hcientist Jul 5, 2024
2323b2d
don't care about this rule
hcientist Jul 5, 2024
b110734
most files are formatted. many linting errors remain, i'm inclined to…
hcientist Jul 5, 2024
0f95f95
fix eslint problems in variations.js
mfwolffe Jul 12, 2024
61eb0b6
flatjs and performjs eslint
mfwolffe Jul 12, 2024
4ad2f89
recentSubmissionjs; verify camelcase rename does not break
mfwolffe Jul 12, 2024
ba5fe80
piece picker - switch to useCallback() to satisfy linter
mfwolffe Jul 12, 2024
0a4c0a8
imports out of order
mfwolffe Jul 12, 2024
b4d3344
theoreticaljs eslint; preferred approach for array indices in div keys?
mfwolffe Jul 12, 2024
aca0013
exploratoryjs linter; mostly useCallbacks
mfwolffe Jul 12, 2024
475a9d5
dropped nested ternary since it was overcomplicated anyway, these are…
hcientist Aug 5, 2024
30834f8
Merge pull request #2 from hcientist/standardize_format
mfwolffe Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 50 additions & 39 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,55 @@
{
"env": {
"browser": true,
"es2021": true
"env": {
"browser": true,
"es2021": true
},
"extends": [
"plugin:react/recommended",
"airbnb",
"prettier"
],
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"extends": [
"plugin:react/recommended",
"airbnb",
"prettier"
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": [
"react",
"eslint-plugin-prettier"
],
"rules": {
"react/jsx-filename-extension": [
1,
{
"extensions": [
".js",
".jsx"
]
}
],
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": [
"react"
"no-console": "off",
"no-unused-vars": "off",
"react/react-in-jsx-scope": "off",
"import/prefer-default-export": "off",
"indent": [
"off",
0
],
"rules": {
"react/jsx-filename-extension": [
1,
{
"extensions": [
".js",
".jsx"
]
}
],
"no-console": "off",
"no-unused-vars": "off",
"react/react-in-jsx-scope": "off",
"indent": [
"warn",
2
],
"react/prop-types": "off",
"default-param-last": "off",
"default-case": "off",
"no-case-declarations": "off",
"jsx-a11y/anchor-is-valid": "off"
}
"react/prop-types": "off",
"default-param-last": "off",
"default-case": "off",
"no-case-declarations": "off",
"jsx-a11y/anchor-is-valid": "off",
"prettier/prettier": [
"error",
{
"singleQuote": true,
"tabWidth": 2,
"semi": true,
"endOfLine": "lf"
}
]
}
}
4 changes: 3 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"editor.defaultFormatter": "esbenp.prettier-vscode",
"[javascript]": { "editor.defaultFormatter": "dbaeumer.vscode-eslint" },
"[javascriptreact]": { "editor.defaultFormatter": "rvest.vs-code-prettier-eslint" },
"[typescript]": { "editor.defaultFormatter": "rvest.vs-code-prettier-eslint" },
"editor.formatOnPaste": true,
"editor.formatOnSave": true,
"editor.formatOnType": true
Expand Down
Loading
Loading