Use hardware bandpass for sky level #470
Conversation
…nd updated effective aperture diameter
There was a problem hiding this comment.
Generally looks good, but I'm wondering about the best way to set RUBIN_AREA. From the default config here, photons are initially sampled from an annulus with an effective diameter of d = 2 * sqrt(4.18**2 - 2.55*2) = 703 cm, not 642 or 649 cm. I'm wondering if that later figure is some kind of FOV averaged effective diameter that integrates the vignetting. Since the vignetting is emergent, I'd have guessed we want to use the 703 cm figure for determining the initial flux.
|
Based on the description in SMTN-002, it looks like we should be using 703 cm, or perhaps more properly, computing the diameter from the values in that config. |
|
Yep, I agree. I wonder what the best way to compute this programmatically is... We could put the inner/outer diameter into Using 703 cm as the default seems reasonable to me. (I suspect the median-over-FOV value is closer to this than to 642). |
There's a typo here. Using |
|
I'll also fix the pupil area in the skycat.py and instcat.py code in this PR. |
|
@jmeyers314 I've hooked up everything to use the |
| @@ -39,6 +39,9 @@ eval_variables: | |||
| type: Degrees | |||
| theta: { type: OpsimData, field: rotTelPos } | |||
|
|
|||
| fpupil_R_outer: 4.18 | |||
| fpupil_R_inner: 2.55 # M1 inner diameter is 2.558, but we need a bit of slack for off-axis rays | |||
|
|
|||
There was a problem hiding this comment.
Maybe just put fpupil_area here once rather than duplicating the code?
There was a problem hiding this comment.
Sure, I had thought that we might want to access those values individually at some point, but the skycat and instcat implementations indeed probably don't need that.
This addresses #453