Fix Dirichlet character for newform orbit whose dimension is 1 #6318
+56
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt of fixing #6309 . The
hecke_ring_character_values
field in this file seems to have double meaning: the generator value can be either the actual dirichlet character value (the complex e^{...}), or the log of it. Which way to interpret it depends on the existence of non-0hecke_ring_cyclotomic_generator
. Meanwhile,ConreyCharacter.values_gens
always return the log value. This creates a discrepancy in this specificdim==1
code block, wherehecke_ring_cyclotomic_generator
is set to 0 (meaninghecke_ring_character_values
should be interpreted as the final values), buthecke_ring_character_values
stores the log values. A small transformation is needed hereA similar transformation is done here:
lmfdb/lmfdb/classical_modular_forms/download.py
Line 27 in 65713a6