Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main -> web #6295

Merged
merged 89 commits into from
Dec 12, 2024
Merged

main -> web #6295

merged 89 commits into from
Dec 12, 2024

Conversation

roed314
Copy link
Contributor

@roed314 roed314 commented Dec 9, 2024

No description provided.

@roed314
Copy link
Contributor Author

roed314 commented Dec 10, 2024

@edgarcosta Are the BHKSSW and Stein-Watkins files available on production to support the new dataset pages?

@AndrewVSutherland @jvoight @jwj61 @jenpaulhus Are you guys happy with the new database and dataset pages going into production? Since I was the author on the PRs that created them, I don't feel comfortable unilaterally pushing to production.

One motivation to merge this now is to silence the flasklog errors that were fixed by #6293.

@AndrewVSutherland
Copy link
Member

I can take a look this afternoon (NZ time).

@edgarcosta
Copy link
Member

@roed314 no. Are you referring to data/bhkssw_split/ and data/stein_watkins_ecdb?
we are missing the folders:

> bhkssw_ecdb
> bhkssw_split
> maass_forms
> stein_watkins_ecdb

@roed314
Copy link
Contributor Author

roed314 commented Dec 10, 2024

These need to be copied to prodweb1 and prodweb2, right? Can I just scp them from grace?

@edgarcosta
Copy link
Member

it is more complicated than that, as it is an external disk that is read-only. I should be able to take care of it today also NZ afternoon time

@edgarcosta
Copy link
Member

@roed314 do we need both?

18G	bhkssw_ecdb
18G	bhkssw_split

@roed314
Copy link
Contributor Author

roed314 commented Dec 10, 2024

We only need bhkssw_split (see #6297 which is related).

AndrewVSutherland and others added 4 commits December 10, 2024 15:15
Fix some minor typos in BHKSSW and SW dataset templates
@edgarcosta
Copy link
Member

@roed314 what about?

elliptic_curves/elliptic_curve.py:998:        filepath = os.path.join(os.path.expanduser('~/data/bhkssw_ecdb/' + info['filename']))

@roed314
Copy link
Contributor Author

roed314 commented Dec 10, 2024

That is commented out now after #6297.

@edgarcosta
Copy link
Member

the data is there

@edgarcosta edgarcosta merged commit 20fdd17 into web Dec 12, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants