ASA core modules #641
Open
ASA core modules #641
+13,340
−3,092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/sunadjoint-core-modules
There was a problem hiding this comment.
Optional suggestion: use the graphviz extension to generate this
gardner48
requested changes
Jan 28, 2025
| @@ -283,7 +286,7 @@ instead of `SameMajorVersion`. This fixes the issue seen | |||
|
|
|||
| Fixed a CMake bug that caused an MPI linking error for our C++ examples in some | |||
| instances. Fixes [GitHub Issue | |||
| #464](https://github.com/LLNL/sundials/issues/464). | |||
| # 464](https://github.com/LLNL/sundials/issues/464). | |||
There was a problem hiding this comment.
Suggested change
| # 464](https://github.com/LLNL/sundials/issues/464). | |
| #464](https://github.com/LLNL/sundials/issues/464). |
There was a problem hiding this comment.
"indicate checkpoint" -> "indicate a checkpoint"
Comment on lines
+26
to
+29
| .. c:enumerator:: SUNDATAIOMODE_INMEM | ||
|
|
||
| The IO mode for data that is stored in addressable random access memory. | ||
| The location of the memory (e.g., CPU or GPU) is not specified by this mode. |
There was a problem hiding this comment.
Suggested change
| .. c:enumerator:: SUNDATAIOMODE_INMEM | |
| The IO mode for data that is stored in addressable random access memory. | |
| The location of the memory (e.g., CPU or GPU) is not specified by this mode. | |
| .. c:enumerator:: SUNDATAIOMODE_INMEM | |
| The IO mode for data that is stored in addressable random access memory. | |
| The location of the memory (e.g., CPU or GPU) is not specified by this mode. |
| states during forward integration and accessing them as needed during the backwards integration | ||
| of the adjoint model. | ||
|
|
||
| .. c:enum:: SUNDataIOMode |
There was a problem hiding this comment.
Suggested change
| .. c:enum:: SUNDataIOMode | |
| .. c:enum:: SUNDataIOMode | |
| IO modes for storing adjoint checkpoints |
| The SUNDIALS simulation context. | ||
|
|
||
|
|
||
| .. c:type:: struct SUNAdjointCheckpointScheme_Ops_ *SUNAdjointCheckpointScheme_Ops |
There was a problem hiding this comment.
Suggested change
| .. c:type:: struct SUNAdjointCheckpointScheme_Ops_ *SUNAdjointCheckpointScheme_Ops | |
| The virtual table structure is defined as | |
| .. c:type:: struct SUNAdjointCheckpointScheme_Ops_ *SUNAdjointCheckpointScheme_Ops |
| { | ||
| step_data_node = NULL; | ||
| } | ||
| else { SUNCheckCall(errcode); } |
There was a problem hiding this comment.
Why not have SUNCheckCall on the call to SUNDataNode_GetNamedChild?
|
|
||
| SUNErrCode SUNAdjointCheckpointScheme_InsertVector_Fixed( | ||
| SUNAdjointCheckpointScheme self, int64_t step_num, | ||
| SUNDIALS_MAYBE_UNUSED int64_t stage_num, sunrealtype t, N_Vector y) |
There was a problem hiding this comment.
Looks like stage_num is only used for logging, should it be removed?
| stage_num); | ||
| errcode = SUNDataNode_GetChild(step_data_node, stage_num, &solution_node); | ||
| if (errcode == SUN_ERR_DATANODE_NODENOTFOUND) { solution_node = NULL; } | ||
| else { SUNCheckCall(errcode); } |
There was a problem hiding this comment.
Why not have SUNCheckCall on the call to SUNDataNode_GetChild?
Comment on lines
+214
to
+217
| } | ||
|
|
||
| SUNCheckCall(SUNDataNode_HasChildren(step_data_node, &has_children)); | ||
| if (!has_children) |
There was a problem hiding this comment.
Couldn't this be
Suggested change
| } | |
| SUNCheckCall(SUNDataNode_HasChildren(step_data_node, &has_children)); | |
| if (!has_children) | |
| } | |
| else |
|
|
||
| SUNCheckCall(SUNDataNode_Destroy(&IMPL_MEMBER(self, root_node))); | ||
|
|
||
| free(GET_CONTENT(self)); |
There was a problem hiding this comment.
I think this is slightly more clear in this case
Suggested change
| free(GET_CONTENT(self)); | |
| free(self->content); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the core modules that will support adjoint sensitivity analysis in a package-agnostic way.