-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker container for ci test #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer2368
force-pushed
the
docker_ci
branch
12 times, most recently
from
February 5, 2023 05:06
d35c6b5
to
3fed7e0
Compare
dreamer2368
changed the title
Suggestion of using docker container for ci test
Docker container for ci test
Feb 5, 2023
dreamer2368
force-pushed
the
docker_ci
branch
from
February 5, 2023 05:24
3fed7e0
to
720711f
Compare
chldkdtn
approved these changes
May 3, 2023
@debog @dylan-copeland @siuwuncheung @sullan2 Would you mind reviewing this PR? |
sullan2
reviewed
May 3, 2023
sullan2
approved these changes
May 3, 2023
siuwuncheung
reviewed
May 3, 2023
siuwuncheung
reviewed
May 3, 2023
I think I am out of my depths here! |
siuwuncheung
approved these changes
May 3, 2023
Me too, and there are enough approvals already, so I will not review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using docker container, github ci test can contain only
libROM
-related parts for testing. Most installation steps for dependencies can be skipped, which can reduce the linux ci test time from about 15 mins to 5 mins..github/workflows/Dockerfile
.googletest
are pre-installed in the container:Install Linux Dependencies
./.github/workflows/checkout_repo
run: scripts/setup.sh
Set Swap Space
step is not needed any longer, because all dependencies are not installed within ci test. However, this step is still included in the CI test, just in case we may need extra space in the future.Note:
mfem
. While it necessitates manually updating the container occasionally, it also enables a stable CI test and development.Issue:
RandomizedSVDTest
is susceptible to round-off error, failing randomly on different machine. This affects the test result under the container. See Issuetest_RandomizedSVD
failure #193 . Commented the corresponding test until the issue is resolved by a separate pull request.TODO: