remove use of CL namespace to remove compiler warnings #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhornung67
requested review from
adayton1,
kab163,
rchen20,
long58,
trws and
davidbeckingsale
rchen20
approved these changes
Nov 25, 2024
trws
approved these changes
Nov 25, 2024
davidbeckingsale
approved these changes
Nov 25, 2024
kab163
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Intel compilers have deprecated the use of the
CLnamespace. This change squashes a bunch of compiler warnings in RAJA and other user libraries.Let's merge this PR and the CMake version PR after the doc PR is merged (hopefully that will be soon). Then, I think it makes sense to do a camp patch release and pull that into RAJA, Umpire, etc. so we are coordinated. In particular, Other RAJA Suite projects will need to bump their patch version numbers when pulling in the change in this PR because this change will likely require modifications to the dependent library source code to build. For example, see LLNL/RAJA#1772
We will also need to update the version constraints in all of our Spack packages to reduce breakages for downstream users.