Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consistency in WIN32 define checks #384

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add consistency in WIN32 define checks #384

merged 1 commit into from
Jul 29, 2024

Conversation

biagas
Copy link
Collaborator

@biagas biagas commented Jul 29, 2024

Use _WIN32 instead of WIN32 in the #ifdef and #if defined checks.
The former is defined by the compiler, the latter only by the IDE.

Resolves #383.

@biagas
Create consistency with WIN32 define checks
5561fe1 
Use `_WIN32` for the check instead of `WIN32`.
@biagas biagas requested a review from markcmiller86 July 29, 2024 19:45
@biagas biagas merged commit d8eb71c into 4.11RC Jul 29, 2024
1 check failed
@biagas biagas deleted the bugfix/biagas/fix_win32_define_checks branch July 29, 2024 20:33
@biagas biagas mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcmiller86 markcmiller86 markcmiller86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biagas @markcmiller86