Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper submission #47

Merged
merged 2 commits into from
Jan 14, 2025
Merged

JOSS paper submission #47

merged 2 commits into from
Jan 14, 2025

Conversation

astrophpeter
Copy link
Member

This PR contains content for Journal for Open Source Software submission of SAPPY

@astrophpeter astrophpeter marked this pull request as ready for review January 8, 2025 22:34
@astrophpeter
Copy link
Member Author

@aperloff Can you review please, needs to be merged for JOSS submission. :)

@astrophpeter
Copy link
Member Author

or @SuperdoerTrav can review :)

Copy link
Member

@aperloff aperloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the three binary files (two png and one pdf) as LFS tracked files. Make sure to sanitize your history before adding them again.

JOSS/paper.md Outdated Show resolved Hide resolved
JOSS/paper.md Show resolved Hide resolved
@astrophpeter
Copy link
Member Author

Please add the three binary files (two png and one pdf) as LFS tracked files. Make sure to sanitize your history before adding them again.

pdf is now removed. It is not needed for the JOSS submission, but I thought it may be nice for Co-authors to see.

@astrophpeter
Copy link
Member Author

On the LFS of binaries / commit history, @aperloff I'll let you deal with that if it's fast for you?

@aperloff aperloff merged commit 8b05b89 into LLNL:main Jan 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants