LIT-2791 - Modify auto-top-up service to limit number of un-expired NFTs per recipient #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imit number of un-expired NFTs per recipient - Only top-up if a recipient will have 0 un-expired tokens tomorrow
…n cases - Refactored getExistingTokenDetails() to be unit testable (pure) - Fixed a bug where tokens expiring the same day weren't being counted property. Yay tests. - Renamed a variable to avoid thinking in double-negatives :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new logic to avoid minting a new NFT to recipients every day, which would lead to a single recipient having many NFTs in cases where the NFT we mint for them expires many days in the future.
Logic is:
expiredAtformatted string :)).Props to @mmmmveggies for awesome
.filter()prop-based predicate for discriminated unions.. That is fly stuff; I was struggling with how to do that forPromiseSettledResultslast week but gave up :P