Fix some bugs in retrying of operations #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where retrying operations came up with a different cache key so they wouldn't actually update the original operations status. Also handles a potential timeout error if an operation takes more than the default timeout (10 minutes) - this way the error should be shown to the user rather than just failing silently and never updating the operation from in progress. There is still a periodic error I get when retrying operations many times locally:
This only happens sometimes, so I'm not sure what the root cause is but it looks like it only partially downloads or uses the file and then fails due to that?