Properly Remove TempFiles #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or line profile, context manager img utils
jnation3406
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
Adds the context manager decorator to the
create_fits,create_tif, andcreate_jpgsfunctions.This way I can return the file paths to wherever called the function and when its done clean them up.
Also made sure to specify the TEMP_FITS_DIR since there is a cronjob Matt wrote to clean that one, the default was just /tmp. Even though the files are deleted properly now this is just to be extra safe.
Other changes
Example of the context manger properly cleaning the output files out after they're uploaded to s3, inputs remain in the tmp since they're cached to be used in future operations. (cleaned out in an hour)
Screen.Recording.2025-01-29.at.4.53.14.PM.mov