New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

range protection, step not 0 protection, Exception handling with linear bins #47

Merged

LTDakin merged 1 commit into main from fix/zero-division-error

Jan 11, 2025

Contributor

LTDakin commented Jan 10, 2025

Adds three protections when creating bins

if the range are equal numbers it will just return one bin with the number
steps are enforced to be a minimum of 1 since arange requires ints and avoids a division by 0 error
Exceptions are logged with values and falls back to creating a linear array of bins from the zero to max


          range protection, step not 0 protection, Exception handling with line…

…ar bins

LTDakin requested review from jnation3406 and capetillo

January 10, 2025 22:58

LTDakin self-assigned this

jnation3406 approved these changes

View reviewed changes

Contributor

jnation3406 left a comment

Looks good to me

LTDakin merged commit 138145c into main

3 checks passed

LTDakin deleted the fix/zero-division-error branch

January 11, 2025 01:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet