-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update server to have raw-data analysis operation and update rgb oper… #39
Conversation
…ation to require and take in scale parameters for input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of comments
median = np.median(samples) | ||
_, zmax, _ = calc_zscale_min_max(samples, contrast=0.1, iterations=1) | ||
|
||
# resize the image to max. 500 pixels on an axis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
500 or 800?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah were requesting 500 from the frontend, but i guess i made the default 800. confusing
'width': scaled_array.shape[1], | ||
'zmin': int(median), | ||
'zmax': int(zmax), | ||
'bitdepth': 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the frontend we're assuming the bit depth to be 16, right? So this is currently unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup. Just there since you said we might want to handle other bitdepths in the future, but that was too hard for me to do right now.
…ning the tests locally without redis
…ation to require and take in scale parameters for input
The
rgb_stack
operation should show the changes to the wizard description used by the frontend to request data scaling values. It will then expect to receive azmin
andzmax
field for each input image that requested it when adding the operation.