Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned to @cmccully and @jfrostburke that I think we should not delete old calibration files (arc identifications, atmospheric corrections, sensitivity functions) because of two considerations: (1) reducing old data, where the old calibrations are the right ones to use, and (2) being able to reproduce old reductions, where the filenames of the calibration files are stored in the headers of the reduced data. I'm pretty sure this is how it used to work a few years ago, but at some point we started replacing old calibrations instead of just adding new ones.
I confirmed that the pipeline does choose the calibration taken closest in time to the data to be reduced, not just the first one alphabetically (e.g., see the function
floyds.util.searchsens
). This is mostly correct, with the only exception being when there is a drastic change like recoating the mirror or changing the CCD. This is an edge case that we already didn't account for, so I am going to ignore it for now.I went through the git history and recovered as many calibration files as I could and added them under the new directory structure (accounting for en05 vs. en12). This commit simply adds all the files I found back into the repository.