Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include old calibration files #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

griffin-h
Copy link

I mentioned to @cmccully and @jfrostburke that I think we should not delete old calibration files (arc identifications, atmospheric corrections, sensitivity functions) because of two considerations: (1) reducing old data, where the old calibrations are the right ones to use, and (2) being able to reproduce old reductions, where the filenames of the calibration files are stored in the headers of the reduced data. I'm pretty sure this is how it used to work a few years ago, but at some point we started replacing old calibrations instead of just adding new ones.

I confirmed that the pipeline does choose the calibration taken closest in time to the data to be reduced, not just the first one alphabetically (e.g., see the function floyds.util.searchsens). This is mostly correct, with the only exception being when there is a drastic change like recoating the mirror or changing the CCD. This is an edge case that we already didn't account for, so I am going to ignore it for now.

I went through the git history and recovered as many calibration files as I could and added them under the new directory structure (accounting for en05 vs. en12). This commit simply adds all the files I found back into the repository.

@griffin-h
Copy link
Author

I should note there was one file already in the ftn/en06 directory that had 2m0-02/en12 in the header, so I deleted that file. Not sure how it got there (or maybe the header is wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant