Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base scaling off input filter, remove check for correct filter to allow any #153

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

LTDakin
Copy link
Collaborator

@LTDakin LTDakin commented Feb 6, 2025

This change allows for any filter to be added as input for red green and blue in the RGB stack operation.
To do this a filtering step was removed as well as passing down the input type to determine the filter instead of the image's filter.

Also changed the switch case to use a map instead and removed observatories from the text conversion as it was too long inside the table view, but that change is unrelated and can be reverted if need be.

Backend change to allow non aligned images to be stacked is needed to make this work as well

Screen.Recording.2025-02-05.at.4.52.23.PM.mov

@LTDakin LTDakin self-assigned this Feb 6, 2025
@LTDakin LTDakin linked an issue Feb 6, 2025 that may be closed by this pull request
2 tasks
Copy link
Contributor

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but it would be nice to sort the input images by the preferred colors first. So for example, all images are available to select for R, G, B channels, but the order they are presented to you is different for each channel, with the r, R, rp filter images shown first in the R channel and so on. This won't matter much when you have like 5 images in your session, but when you start having 10+ it'll help users see and pick the most common filters for those channels first.

@LTDakin LTDakin requested a review from jnation3406 February 11, 2025 21:36
@LTDakin
Copy link
Collaborator Author

LTDakin commented Feb 11, 2025

@jnation3406 I used the backend wizard description filters field to filter the inputs so that the desired filters are placed at the front of the imageGrid inputs. I also had to change from using index to track the selected images to basenames. This was since the index of the rearranged array is different than the original. I've been wanting to use basenames instead of indexes for a while as well since its more explicit which image is selected vs keeping track of the indexes of them. Tested it to make sure it works still for the projects page when selecting images for a project since the imageGrid and image selection pattern is used there too.

Copy link
Contributor

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and good idea referencing by basename. I'm switching the operations code to reference by operation id instead of index as well for similar reasons.

@LTDakin LTDakin merged commit 5c0c69e into main Feb 12, 2025
@LTDakin LTDakin deleted the update/remove-rgb-filter-restriction branch February 12, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom narrowband filters for RGB stacks
2 participants