Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: key command and key emulation #13

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

amadeo-alex
Copy link

@amadeo-alex amadeo-alex commented Jul 6, 2023

This PR:

  • replaces all usages of "keybd_event" as it has been superseded by "SendInput".
  • fixes how the input emulation was handled - key was never officially "unpressed" - which caused issues with some of the applications (should remediate Bug: "Key" commands end up with key being "held down" HASS.Agent#323)
  • made the "KeyCommand" modification UI display "keycode name" instead of "keycode number" (for example KEY_P)
  • adds note to the "KeyCommand" modification UI about "TAB" key - LCTRL+TAB

I've tested both "KeyCommand" and MediaPlayer - both function as expected after the changes.

@amadeo-alex
Copy link
Author

LAB02-Research/HASS.Agent#229 to be revised after this is merged

@kjack9
Copy link

kjack9 commented Sep 6, 2023

I can confirm that #24 (specifically the changes in amadeo-alex/HASS.Agent.Staging/fix-key-command) fixes this issue entirely in Kodi. Previously I would skip between 2-8 lines when navigating up or down. Now everything works as expected. Thank you!

@kjack9
Copy link

kjack9 commented Sep 6, 2023

LAB02-Research/HASS.Agent#276

This issue is also fixed by amadeo-alex/HASS.Agent.Staging/fix-key-command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants