Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Makefile): enable auto detect compiler #1282

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

xudyang1
Copy link
Contributor

@xudyang1 xudyang1 commented Jan 7, 2025

CC on Windows is usually not set to the correct compiler. #1252 needs manually defined CC to work (i.e., make install_jsregexp CC=compiler). Many users complained about this extra work (#1220 #1278 ).

This PR enables compilers detection in the following order:

  • manually defined CC
  • gcc
  • clang
  • cl
  • zig

@xudyang1 xudyang1 force-pushed the feat/auto-detect-compiler branch from d346f8b to be50e96 Compare January 12, 2025 00:09
@xudyang1 xudyang1 force-pushed the feat/auto-detect-compiler branch from be0594d to e6a5b70 Compare January 12, 2025 02:10
@xudyang1 xudyang1 force-pushed the feat/auto-detect-compiler branch from e6a5b70 to 5c54ffa Compare January 12, 2025 02:26
@xudyang1 xudyang1 force-pushed the feat/auto-detect-compiler branch 3 times, most recently from 07a800e to 5c54ffa Compare January 17, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant