Use event.buf directly to get bufnr #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the neovim's issue (neovim/neovim#16416), using `vim.fn.expand` sometimes throws Keyboard interrupt error when pressing Ctrl-C (a common alternative to Esc). This works around the above issue by simply getting the buffer number from event argument.
leiserfg
approved these changes
Nov 4, 2023
|
Ahhh of course, thank you! |
xu-cheng
added a commit
to xu-cheng/LuaSnip
that referenced
this pull request
Nov 20, 2023
We don't need to use `vim.fn.expand(...)` to get the buffer or file for the autocmd callbacks. Instead, use `event.buf` or `event.file` directly from the callback function argument. See also L3MON4D3#1047.
L3MON4D3
pushed a commit
that referenced
this pull request
Nov 20, 2023
We don't need to use `vim.fn.expand(...)` to get the buffer or file for the autocmd callbacks. Instead, use `event.buf` or `event.file` directly from the callback function argument. See also #1047.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the neovim's issue (neovim/neovim#16416), using
vim.fn.expandsometimes throws Keyboard interrupt error when pressing Ctrl-C (a common alternative to Esc).This works around the above issue by simply getting the buffer number from event argument.