Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArtifactHub.io] GPG public key annotation added #1155

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

didierofrivia
Copy link
Member

Part of the work needed for Kuadrant/helm-charts#18

This PR adds a new annotation in the Helm Chart.yaml meant for displaying the public key used for signing its chart packages. More info in https://artifacthub.io/docs/topics/annotations/helm/

@didierofrivia didierofrivia added the kind/enhancement New feature or request label Feb 3, 2025
@didierofrivia didierofrivia self-assigned this Feb 3, 2025
@didierofrivia didierofrivia requested a review from a team as a code owner February 3, 2025 13:59
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (42d065f) to head (d97e8dd).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   83.37%   83.45%   +0.07%     
==========================================
  Files          81       81              
  Lines        6943     6943              
==========================================
+ Hits         5789     5794       +5     
+ Misses        928      925       -3     
+ Partials      226      224       -2     
Flag Coverage Δ
bare-k8s-integration 22.87% <ø> (+0.18%) ⬆️
controllers-integration 74.94% <ø> (ø)
envoygateway-integration 40.59% <ø> (+0.23%) ⬆️
gatewayapi-integration 19.55% <ø> (+1.07%) ⬆️
istio-integration 43.16% <ø> (-0.22%) ⬇️
unit 19.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <ø> (ø)
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (ø)
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (ø)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.78% <ø> (+0.15%) ⬆️

see 5 files with indirect coverage changes

@didierofrivia didierofrivia added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 1ffadbc Feb 4, 2025
42 checks passed
@didierofrivia didierofrivia deleted the helm-pub-key branch February 4, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants