Signing Helm packages #1151
Merged
Signing Helm packages #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
+ Coverage 83.45% 83.63% +0.18%
==========================================
Files 81 81
Lines 6943 6943
==========================================
+ Hits 5794 5807 +13
+ Misses 925 913 -12
+ Partials 224 223 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7 tasks
eguzki
previously approved these changes
Feb 4, 2025
Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
* Needs an extra step because svenstaro/upload-release-action@v2 doesn't support asset naming on file_glob Signed-off-by: dd di cesare <[email protected]>
Signed-off-by: dd di cesare <[email protected]>
* the GnuPG v2 store the secret keyring using the format kbx and Helm works with the legacy gpg format. * Enclosing within quotes to fix env interpolation Signed-off-by: dd di cesare <[email protected]>
didierofrivia
force-pushed
the
helm-sign-packages
branch
from
dc67732 to
9f79273
Compare
eguzki
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work needed for Kuadrant/helm-charts#18
This PR introduces the GPG signing of Helm chart packages upon creation. It also uploads its provenance file to the GH release page.
The job now requires to be passed an environment variable GPG_KEYRING_BASE64 which represents the GPG keyring base64 encoded, in order to be stored as a GH action variable.
The following PRs need to be merged first: