Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RateLimit.Conditions need explicit scope #1145

Merged
merged 1 commit into from
Jan 30, 2025

RateLimit.Conditions need explicit scope

42d065f
Select commit
Loading
Failed to load commit list.
Merged

RateLimit.Conditions need explicit scope #1145

RateLimit.Conditions need explicit scope
42d065f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 0s

83.37% (+0.04%) compared to 6df1dbf

View this Pull Request on Codecov

83.37% (+0.04%) compared to 6df1dbf

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.37%. Comparing base (6df1dbf) to head (42d065f).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   83.33%   83.37%   +0.04%     
==========================================
  Files          81       81              
  Lines        6943     6943              
==========================================
+ Hits         5786     5789       +3     
+ Misses        930      928       -2     
+ Partials      227      226       -1     
Components Coverage Δ
api/v1beta1 (u) 90.00% <ø> (ø)
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (ø)
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (ø)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.63% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
controllers/limitador_limits_reconciler.go 86.31% <100.00%> (ø)

... and 7 files with indirect coverage changes