Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bump codecov retry limit to 10 #613

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 7, 2023

It seems that there's been occasions where the retry helped (e.g. here https://github.com/Kong/kubernetes-testing-framework/actions/runs/4630922396/jobs/8193283484?pr=609 2 failed attempts and the third being successful) whereas sometimes even 3 retries is not enough (e.g. here https://github.com/Kong/kubernetes-testing-framework/actions/runs/4630922396/jobs/8193283631?pr=609)

To try to address this let's bump the limit of retries to 10.

@pmalek pmalek added the area/ci label Apr 7, 2023
@pmalek pmalek self-assigned this Apr 7, 2023
@pmalek pmalek requested review from a team and shaneutt as code owners April 7, 2023 08:41
@pmalek pmalek enabled auto-merge (squash) April 7, 2023 08:41
@pmalek pmalek temporarily deployed to gcloud April 7, 2023 08:41 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.24 ⚠️

Comparison is base (d9f1e72) 58.15% compared to head (877181c) 55.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   58.15%   55.92%   -2.24%     
==========================================
  Files          43       43              
  Lines        3451     3451              
==========================================
- Hits         2007     1930      -77     
- Misses       1178     1268      +90     
+ Partials      266      253      -13     
Flag Coverage Δ
integration-test 55.92% <ø> (-2.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmalek pmalek temporarily deployed to gcloud April 7, 2023 09:06 — with GitHub Actions Inactive
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about why it needs to retry but since a part of this is somewhat out of our control and if we see that a couple more retries might help, sure.

@pmalek pmalek temporarily deployed to gcloud April 7, 2023 12:17 — with GitHub Actions Inactive
@pmalek
Copy link
Member Author

pmalek commented Apr 7, 2023

Curious about why it needs to retry but since a part of this is somewhat out of our control and if we see that a couple more retries might help, sure.

It seems that it's more than just us experiencing this issue: codecov/codecov-action#926

@pmalek pmalek merged commit 85b233d into main Apr 7, 2023
@pmalek pmalek deleted the bump-codecov-retry-limit branch April 7, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants