Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): api service use axios from @kong-ui-public/entities-shared #358

Conversation

exuan
Copy link
Contributor

@exuan exuan commented Jan 3, 2025

Summary

Updated Axios instance initialization to prioritize useAxios().axiosInstance from @kong-ui-public/entities-shared
Adds support api service withCredentials

Issue reference

Fix #[issue number]

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2025

CLA assistant check
All committers have signed the CLA.

@exuan exuan force-pushed the feat-api-service-use-axios-from-entities-shared branch from ac2f5bf to 30b0ba2 Compare January 4, 2025 05:34
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 224c829 into Kong:main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants