-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: paths in gRPC requests and proto state #8284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-willis
force-pushed
the
fix/grpc-issues
branch
from
January 8, 2025 21:45
f334b83
to
aaac354
Compare
1 task
ryan-willis
force-pushed
the
fix/grpc-issues
branch
from
January 9, 2025 14:15
b43f107
to
6d1544b
Compare
ryan-willis
force-pushed
the
fix/grpc-issues
branch
from
January 16, 2025 15:34
6d1544b
to
a3c8e2d
Compare
ryan-willis
changed the title
fix: paths in gRPC requests
fix: paths in gRPC requests and proto state
Jan 17, 2025
ryan-willis
force-pushed
the
fix/grpc-issues
branch
from
January 21, 2025 15:22
1fb8d93
to
ba449e3
Compare
marckong
approved these changes
Jan 21, 2025
jackkav
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very thorough work, easy to review too thanks!
Only feedback would be to add any future work or implementation ideas or uncertainties in the pr description for completeness. Eg something you could have done if more time was spent on it but was scoped out
CurryYangxx
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test the majority of this, follow the steps in my comment here
Changes: