Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paths in gRPC requests and proto state #8284

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

ryan-willis
Copy link
Contributor

@ryan-willis ryan-willis commented Jan 8, 2025

To test the majority of this, follow the steps in my comment here

Changes:

@ryan-willis ryan-willis changed the title Fix/grpc issues fix: paths in gRPC requests Jan 9, 2025
@ryan-willis ryan-willis changed the title fix: paths in gRPC requests fix: paths in gRPC requests and proto state Jan 17, 2025
@ryan-willis ryan-willis marked this pull request as ready for review January 21, 2025 15:25
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough work, easy to review too thanks!

Only feedback would be to add any future work or implementation ideas or uncertainties in the pr description for completeness. Eg something you could have done if more time was spent on it but was scoped out

@ryan-willis ryan-willis merged commit dcb13ea into Kong:develop Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants