Insomnia Format v5 #8209
Draft
Insomnia Format v5 #8209
+1,253
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
cb41723 to
b24bbe8
Compare
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
b24bbe8 to
2ec7d17
Compare
yaoweiprc
reviewed
Dec 10, 2024
packages/insomnia/package.json
Outdated
| "yaml-source-map": "^2.1.1" | ||
| "yaml-source-map": "^2.1.1", | ||
| "zod": "^3.23.8", | ||
| "zod-to-json-schema": "^3.23.3" |
There was a problem hiding this comment.
It seems that zod-to-json-schema is not used.
yaoweiprc
reviewed
Dec 10, 2024
|
|
||
| const apiSpecSchema = z.object({ | ||
| type: z.literal('spec.insomnia.rest/5.0'), | ||
| meta: MetaSchema.optional(), |
There was a problem hiding this comment.
Can use zod extend method to remove duplicate codes.
yaoweiprc
reviewed
Dec 11, 2024
| resources.push(requestGroup); | ||
|
|
||
| walkCollection(item.children, requestGroup._id); | ||
| } else if ('method' in item) { |
There was a problem hiding this comment.
I think that we need a type field to identity what entity it is.
yaoweiprc
reviewed
Dec 11, 2024
| function getCollectionFromResources(resources: (Request | RequestGroup | WebSocketRequest | GrpcRequest)[], parentId: string): Extract<InsomniaFile, { type: 'collection.insomnia.rest/5.0' }>['collection'] { | ||
| const collection: Extract<InsomniaFile, { type: 'collection.insomnia.rest/5.0' }>['collection'] = []; | ||
|
|
||
| resources.filter(resource => resource.parentId === parentId).forEach(resource => { |
There was a problem hiding this comment.
Can build the tree in O(n) time.
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
2 times, most recently
from
46dc254 to
f76755b
Compare
gatzjames
force-pushed
the
feature/ins-4397-spike-propose-new-formats-for-our-v5-specification
branch
from
d9a32a4 to
6124ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring the new v5 format: