Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runner/settings): enable logging switch configuration #8194

Merged
merged 13 commits into from
Jan 7, 2025
Merged

feat(runner/settings): enable logging switch configuration #8194

merged 13 commits into from
Jan 7, 2025

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Nov 22, 2024 •
edited
Loading

Changes

  • Supported turning on/off logging by introducing runtime
  • Added smoke test

Ref: INS-4421

@ihexxa ihexxa self-assigned this Nov 22, 2024
@ihexxa ihexxa marked this pull request as draft November 22, 2024 02:36
@ihexxa ihexxa force-pushed the feat/runner/cfg-log branch 2 times, most recently from 4af3284 to 988bceb Compare November 28, 2024 02:56
@ihexxa ihexxa force-pushed the feat/runner/cfg-log branch 2 times, most recently from feade75 to 82c4067 Compare December 27, 2024 07:57
@ihexxa ihexxa requested a review from a team January 2, 2025 09:30
@ihexxa ihexxa marked this pull request as ready for review January 2, 2025 09:30
@cwangsmv cwangsmv self-requested a review January 3, 2025 02:50
cwangsmv
cwangsmv previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@cwangsmv cwangsmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn on/off log feature in collection runner is working as expected with the change.

packages/insomnia/src/network/network.ts Outdated Show resolved Hide resolved
packages/insomnia/src/ui/routes/request.tsx Outdated Show resolved Hide resolved
@ihexxa ihexxa force-pushed the feat/runner/cfg-log branch from e81361a to 2aa12d9 Compare January 6, 2025 06:13
@ihexxa ihexxa force-pushed the feat/runner/cfg-log branch from 9141985 to bc68dc5 Compare January 7, 2025 02:45
cwangsmv
cwangsmv approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@cwangsmv cwangsmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ihexxa ihexxa merged commit 37ef377 into develop Jan 7, 2025
8 checks passed
@ihexxa ihexxa deleted the feat/runner/cfg-log branch January 7, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwangsmv cwangsmv cwangsmv approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihexxa @cwangsmv