1.add enableVaultInScripts settings to allow using vault in script

2.fix editor bug
Kong · Jan 7, 2025 · 40dffb4 · 40dffb4
1 parent bfb3d55
commit 40dffb4
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/packages/insomnia/src/common/settings.ts b/packages/insomnia/src/common/settings.ts
@@ -148,4 +148,5 @@ export interface Settings {
   // vault related settings
   saveVaultKeyToOSSecretManager: boolean;
   vaultSecretCacheDuration: number;
+  enableVaultInScripts: boolean;
 }
diff --git a/packages/insomnia/src/models/settings.ts b/packages/insomnia/src/models/settings.ts
@@ -72,6 +72,7 @@ export function init(): BaseSettings {
     validateSSL: true,
     vaultSecretCacheDuration: 30,
     saveVaultKeyToOSSecretManager: true,
+    enableVaultInScripts: false,
   };
 }
 

diff --git a/...ages/insomnia/src/ui/components/editors/environment-key-value-editor/key-value-editor.tsx b/...ages/insomnia/src/ui/components/editors/environment-key-value-editor/key-value-editor.tsx
@@ -144,6 +144,10 @@ export const EnvironmentKVEditor = ({ data, onChange, vaultKey = '', isPrivate =
             }
           },
         });
+      } else if (newType === EnvironmentKvPairDataType.SECRET) {
+        // encrypt value if set to secret type
+        handleItemChange(id, 'value', encryptSecretValue(originValue, symmetricKey));
+        handleItemChange(id, 'type', newType);
       } else {
         handleItemChange(id, 'type', newType);
       }

diff --git a/packages/insomnia/src/ui/components/settings/vault-key-panel.tsx b/packages/insomnia/src/ui/components/settings/vault-key-panel.tsx
@@ -176,6 +176,13 @@ export const VaultKeyPanel = () => {
             setting="saveVaultKeyToOSSecretManager"
           />
         </div>
+        <div className="form-row pad-top-sm">
+          <BooleanSetting
+            label="Enable vault in scripts"
+            help="Allow pre-request and after-response script to access vault secrets."
+            setting='enableVaultInScripts'
+          />
+        </div>
         </>
       }
       {/* User has not input vault key after re-login */}