Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added new gh workflow for improving OSS gateway testing. #1531

Closed
wants to merge 1 commit into from

Conversation

Prashansa-K
Copy link
Contributor

At the moment, we only rely on kong/kong image
for testing for OSS gateway. We have found cases
where users use kong/kong-gateway image, without
a license, to use as an OSS. To deal with these
scenarios and ensure deck works seemlessly with
them, we are adding this new workflow which uses
the EE image but has no license.

At the moment, we only rely on kong/kong image
for testing for OSS gateway. We have found cases
where users use kong/kong-gateway image, without
a license, to use as an OSS. To deal with these
scenarios and ensure deck works seemlessly with
them, we are adding this new workflow which uses
the EE image but has no license.
@Prashansa-K
Copy link
Contributor Author

Found the need for this from here: #1522

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.09%. Comparing base (fb7365f) to head (c7c5f4f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1531   +/-   ##
=======================================
  Coverage   29.09%   29.09%           
=======================================
  Files          62       62           
  Lines        6682     6682           
=======================================
  Hits         1944     1944           
  Misses       4599     4599           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Prashansa-K
Copy link
Contributor Author

The check for enterprise in tests relies on the presence of string "enterprise" in kong version. So, enterprise tests are bound to fail here.
Thus, closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants