feat: adding consumer-group policy overrides support in deck #1518
Conversation
Prashansa-K
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
- Coverage 29.28% 29.09% -0.19%
==========================================
Files 62 62
Lines 6653 6682 +29
==========================================
- Hits 1948 1944 -4
- Misses 4567 4599 +32
- Partials 138 139 +1 ☔ View full report in Codecov by Sentry. |
|
@harshadixit12 I have added the fixes to Konnect integration test in this separate PR: #1519, so that this PR doesn't become massive. |
| @@ -1925,6 +1925,11 @@ const complexQueryForDegraphqlRoute = `query SearchPosts($filters: PostsFilters) | |||
| } | |||
| ` | |||
|
|
|||
| const errorConsumerGroupPolicies = "a rate-limiting-advanced plugin with config.consumer_groups\n" + | |||
There was a problem hiding this comment.
Should we capitalise the first letter of error message?
There was a problem hiding this comment.
This error comes from GDR. It is copied as it is. https://github.com/Kong/go-database-reconciler/blob/main/pkg/utils/utils.go#L29
Also, errors in go are not capitalised by convention. You get lint warnings for the same.
|
@Prashansa-K had a few questions -
|
|
…not fail (#1519) * tests: separated Konnect tests to ensure kong version retrieval does not fail * tests: fixed test for dql routes in konnect * tests: fixed test condition * tests: fixed deck token setting position
Proposal Draft: https://konghq.atlassian.net/wiki/spaces/A/pages/4357751187/Consumer+Group+Policy+Overrides+with+Deck
Related GDR changes: Kong/go-database-reconciler#191