Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dockerfile #6
Add dockerfile #6
Changes from 5 commits
17fd3b9
5b66d38
2c71b04
0b1ed07
34d4a2a
ad343c4
7f4a5ab
57f188f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VCS stamping fails if there is no
.git
folder, this was a workaround. It is because the.git
is a file, not a folder when its a submodule.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
GOFLAGS=-buildvcs=false
env should disable VCS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does, but then later when it looks for the version stamp which is required, it fails. I think this is part of the "daemon version validation" consensus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if initializing fresh git context will cause any problem. Maybe there's a better solution instead of removing the actual git state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not every use case requires
init.py
to be run. We should provide a plain nucleus daemon and leave the rest to the users. How about simply copyinginit.py
(without running) into the container?Also
addrbook.json
file can be moved into https://github.com/KomodoPlatform/nucleus-assets repository.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copying init.py into container will mean needing to add some extra py related deps, and it wont work unless we also copy the app.toml template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, maybe just copy the
nucleusd
binary and leave rest to the users. You can easily mount files/directories inside the container anyway.As we providing the bare container for nucleus, I would pick one of debian images (like 1.22.1-bookworm) just to make install/configure parts of custom workflows easier for people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need
nucleusd
andinit.py
from the builder.