Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows installer #2292

Merged
merged 6 commits into from
Jun 13, 2023
Merged

Update windows installer #2292

merged 6 commits into from
Jun 13, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jun 11, 2023

Closes #2108

  • Incremented version
  • Created DEX_VERSION cmake variable
  • Change windows installer path to include version
  • Tweaked installer to detect existing installation and remove it before installng

To test:

  • Install the app on windows.
  • Run the installer on windows again.
  • On second installation, you should see a warning message about existing installation in folder.
  • Continue anyway
  • App should install without complaining.

@smk762 smk762 marked this pull request as draft June 11, 2023 14:58
@smk762 smk762 marked this pull request as ready for review June 11, 2023 16:27
Copy link

@endrilickollari endrilickollari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in Windows 10:

Did the installation before, installed again warning message appeared:

image

Did the installation anyway and looked good:

image

@kivqa
Copy link

kivqa commented Jun 12, 2023

@smk762
Every installation in same folder displayed as uniqe instance in Control Panel > Programs > Programs and features for Windows 10
If user uninstalls one of these instances then remained instances displayed incorrectly
telegram-cloud-photo-size-2-5206575539551324669-y

PR could be approved if it's not critical issue . Or we can submit separate issue.

@smk762
Copy link
Collaborator Author

smk762 commented Jun 12, 2023

Thanks for report - I'll see how that can be fixed. What happens when you try to uninstall one of the duplicates from add/remove programs?

@kivqa
Copy link

kivqa commented Jun 12, 2023

The instances are remained in the program list without icons and it's possible to remove without any affect . But need to test behavior with different folders for instances

@smk762 smk762 merged commit 014b3df into update_api Jun 13, 2023
@smk762 smk762 deleted the update-windows-installer branch August 7, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants