Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(best-orders): return an rpc error when we can't find best orders #2318

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

mariocynicys
Copy link
Collaborator

Return an RPC error in best orders rpc if we were not able to get the best orders because nobody in the network replied to our p2p request.
This is saner that returning a successful result with no best orders inside.

Kinda addresses #2228

@mariocynicys
Copy link
Collaborator Author

in progress since i will check also other p2p interacting RPCs and apply the same patch to.
p2p interactions aren't guaranteed to succeed, so we should make that obvious/visible from the RPC side.

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's been a month, can you share the status quo of this PR?

Changes seem harmless, so the current status is also LGTM.

@mariocynicys
Copy link
Collaborator Author

@onur-ozkan there is one last place we ask for any peer's response but we don't error.
i opted for not erroring here since part of the response is computed from local data and isn't completely dependent p2p network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants