Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loosen wss filter #1255

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

loosen wss filter #1255

wants to merge 8 commits into from

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jan 14, 2025

fixes where filter would reject non-electrum coins

@smk762 smk762 requested a review from cipig January 14, 2025 08:46
cipig
cipig approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix
wss config now contains tokens too and they have only wss urls configured

@smk762
Copy link
Collaborator Author

smk762 commented Jan 14, 2025

Will await additional testing before merge to confirm removal of nodes.url has no unintended effects.

@cipig cipig self-requested a review January 15, 2025 05:19
@cipig
Copy link
Member

cipig commented Jan 15, 2025

Will await additional testing before merge to confirm removal of nodes.url has no unintended effects.

you were right to wait, if url is removed from RPCs, tokens can't be enabled any more, so 0acf87f needs to be reverted... sorry
tested the result (utils/coins_config_wss.json) without that commit in Web and it works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig Awaiting requested review from cipig

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smk762 @cipig