Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add alfajores #8

Merged
merged 10 commits into from
Dec 23, 2023
Merged

Feat: Add alfajores #8

merged 10 commits into from
Dec 23, 2023

Conversation

fabianschu
Copy link
Contributor

@fabianschu fabianschu commented Dec 19, 2023 •
edited
Loading

Screenshot 2023-12-22 at 16 27 43

closes #11

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
regenerative-fi-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 11:23am

@fabianschu fabianschu changed the title Feat: Add alfajores [WIP] Feat: Add alfajores Dec 19, 2023
@fabianschu fabianschu changed the title [WIP] Feat: Add alfajores Feat: Add alfajores Dec 22, 2023
Another-DevX
Another-DevX requested changes Dec 22, 2023
View reviewed changes
Copy link
Member

@Another-DevX Another-DevX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, though the two comments I left are mainly about scalability and clean code. I'm not a fan of hardcoded elements when they can be centralized, but if it has to be that way, it's not a problem.
:)

src/assets/data/contracts/alfajores.json Outdated Show resolved Hide resolved
src/lib/config/alfajores/contracts.ts Outdated Show resolved Hide resolved
@fabianschu fabianschu merged commit 2b83f45 into develop Dec 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Another-DevX Another-DevX Awaiting requested review from Another-DevX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add Alfajores
2 participants
@fabianschu @Another-DevX