Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another dev/fix feedback issues #10

Merged
merged 38 commits into from
Jan 9, 2024

Conversation

Another-DevX
Copy link
Member

Description

Please include a summary of the change and if relevant which issue is fixed. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
regenerative-fi-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 11:42pm

@fabianschu
Copy link
Contributor

I believe this contains a lot of changes that are already included in develop. Can this be rebased or made clear otherwise which changes still need to be reviewed? @Another-DevX

@Another-DevX
Copy link
Member Author

I believe this contains a lot of changes that are already included in develop. Can this be rebased or made clear otherwise which changes still need to be reviewed? @Another-DevX

I've rebased and merged with the develop branch. This PR contains many visual feedback issues and needs to be merged into the dev branch.

Copy link
Contributor

@fabianschu fabianschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to next time not merge, but just rebase on develop and force push to the respective branch (Another dev/fix feedback issues). This makes the PR a lot cleaner. Otherwise, looks good to me. Feel free to merge 👍🏼

@Another-DevX Another-DevX merged commit a10f450 into develop Jan 9, 2024
5 checks passed
@Another-DevX Another-DevX deleted the AnotherDev/fix-feedback-issues branch January 9, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants