-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another dev/fix feedback issues #10
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I believe this contains a lot of changes that are already included in |
I've rebased and merged with the develop branch. This PR contains many visual feedback issues and needs to be merged into the dev branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to next time not merge, but just rebase on develop and force push to the respective branch (Another dev/fix feedback issues
). This makes the PR a lot cleaner. Otherwise, looks good to me. Feel free to merge 👍🏼
Description
Please include a summary of the change and if relevant which issue is fixed. Please also include relevant motivation and context.
Type of change
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.
Visual context
Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.
Checklist:
master
if hotfix,develop
if not