Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stations Road to Asia, Red Sea Map, Viva Malta, Project Greenland #161

Closed
wants to merge 7 commits into from

Conversation

keremguvercin
Copy link
Contributor

No description provided.

@keremguvercin keremguvercin changed the title Update stations-europe.js Update stations Road to Asia, Red Sea Map, Viva Malta Sep 14, 2021
@keremguvercin keremguvercin changed the title Update stations Road to Asia, Red Sea Map, Viva Malta Update stations Road to Asia, Red Sea Map, Viva Malta, Project Greenland Sep 14, 2021
@rafaelkai
Copy link
Contributor

You might want to add the image files locally, URLs can change

@Koenvh1
Copy link
Owner

Koenvh1 commented Nov 8, 2021

Please add the images for the stations locally. Links don't last forever, and with several thousand stations you are hunting broken links daily.

@gitguardian
Copy link

gitguardian bot commented Dec 30, 2021

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret e4d436e web/stations/stations-europe.js 12:57 January 17th, 2022 View secret
Generic High Entropy Secret fe945f4 web/stations/stations-europe.js 12:57 January 17th, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

@rafaelkai
Copy link
Contributor

Please add the images for the stations locally. Links don't last forever, and with several thousand stations you are hunting broken links daily.

He has already added the images locally in #171
Total of his work would be: #160 #161 #171

@Koenvh1
Copy link
Owner

Koenvh1 commented Sep 12, 2022

Merged with #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants