Rename internal_temperature to internalTemperature to correct typo
#26114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Every attribute on the Inovelli converter is currently using camelCase: https://github.com/Koenkk/zigbee-herdsman-converters/blob/ea46a3f4c46e35f5ce0ec938f9e4f33ac0f6556c/src/devices/inovelli.ts#L315 If I change that, it will cause a breaking change for everyone and I'd prefer to avoid that... Thoughts? |
|
That's not ideal indeed, then let's keep it like this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #25289, I exposed the internal_temperature sensor from Inovelli devices with the correct device class, however, the actual sensor is called
internalTemperatureand notinternal_temperature. Correcting that mistake here.