Add Home Assistant device class for flow rates (e.g., Sonoff SWV) #26035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tathamoddie
force-pushed
the
ha_flow_rate
branch
from
41d380a to
016a50f
Compare
tathamoddie
changed the title
tathamoddie
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports devices like the SONOFF SWV (Smart Water Valve), which has an entity called
Flow, with units ofm³/h.Adding the device class makes it easier to natively convert this value to other units, like
L/min.This change is aligned with lib/modernExtend.flow, which has a unit of
m³/h.It won't cover the Neo NAS-WV03B device, as it exposes an entity called
water_currentinstead. I don't know how best to handle this scenario -- renaming it toflowwould impact users of that device, but it also doesn't look like a go-forward name so it doesn't seem sensible to addwater_currentto the HA mappings. (And "water current" is funny wording in the first place.)I couldn't find any other devices exposing a water flow rate.