Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add): PO-THCO-EAU #8729

Merged
merged 7 commits into from
Feb 5, 2025
Merged

feat(add): PO-THCO-EAU #8729

merged 7 commits into from
Feb 5, 2025

Conversation

gbrunois
Copy link
Contributor

@gbrunois gbrunois commented Feb 4, 2025

Add new device PO-THCO-EAU according to this issue : #8245

@gbrunois gbrunois marked this pull request as draft February 4, 2025 12:57
@gbrunois gbrunois marked this pull request as ready for review February 4, 2025 13:19
@reguiny
Copy link

reguiny commented Feb 4, 2025

I have 2 models :
_TZE284_tbgecldg.
_TZE200_tbgecldg

@gbrunois
Copy link
Contributor Author

gbrunois commented Feb 4, 2025

I have 2 models : _TZE284_tbgecldg. _TZE200_tbgecldg

This code has been tested only with _TZE284_tbgecldg

@reguiny
Copy link

reguiny commented Feb 4, 2025

I use both with the same code and they work exactly the same.

@reguiny
Copy link

reguiny commented Feb 4, 2025

If i am reading it correctly, In your code it appears to be _TZE204_tbgecldg. 0 not 8.

@gbrunois
Copy link
Contributor Author

gbrunois commented Feb 4, 2025

If i am reading it correctly, In your code it appears to be _TZE204_tbgecldg. 0 not 8.

You're right, it's _TZE204_tbgecldg. I used the generated external definition to obtain the fingerprint.

@Koenkk
Copy link
Owner

Koenkk commented Feb 4, 2025

@gbrunois you can safely add these: _TZE284_tbgecldg, _TZE200_tbgecldg, these should be the same devices (as the postfix is the same)

@reguiny
Copy link

reguiny commented Feb 5, 2025

I have tried your code and the battery level is reported at over 100%.
I use this setting which works for me:
'battery', tuya.valueConverterBasic.scale(0, 100, 50, 150)],

@Koenkk Koenkk merged commit 80c08ec into Koenkk:master Feb 5, 2025
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Feb 5, 2025

Thanks!

Could you also submit a picture for the docs? This can be done by:

  1. Create a fork by clicking here
  2. Go to the public/images/devices directory, Add file -> Upload files
  3. Upload the files and press Commit changes
  4. Press Contribute -> Open pull request -> update title/description -> Create pull request

Make sure that:

  • The filename is PO-THCO-EAU.png
  • The size is 512x512
  • The background is transparent (use e.g. Adobe remove background)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants