add new device EFEKTA_Air_Quality_Station #8726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new device EFEKTA_Air_Quality_Station
add new device EFEKTA_Air_Quality_Station
add new device EFEKTA_Air_Quality_Station
add new device EFEKTA_Air_Quality_Station
add new device EFEKTA_Air_Quality_Station
add new device EFEKTA_Air_Quality_Station
Koenkk
reviewed
Feb 4, 2025
src/devices/efekta.ts
Outdated
| access: 'STATE_SET', | ||
| }), | ||
| m.binary({ | ||
| name: 'automatic_scal', |
There was a problem hiding this comment.
Suggested change
| name: 'automatic_scal', | |
| name: 'automatic_self_calibration', |
Koenkk
reviewed
Feb 4, 2025
src/devices/efekta.ts
Outdated
| model: 'EFEKTA_Air_Quality_Station', | ||
| vendor: 'EFEKTA', | ||
| description: | ||
| '[EFEKTA Air Quality Station, PM1.0, PM2.5, PM4.0, PM10, AQ PM2.5 Index, PM Size, CO2, VOC Index, Temperature, \ |
There was a problem hiding this comment.
Please change the description to just Air Quality Station, link can be included on the docs page.
There was a problem hiding this comment.
Hello, I have made changes, which I will also take into account in subsequent converters.
add new device EFEKTA_Air_Quality_Station
add new device EFEKTA_Air_Quality_Station
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new device EFEKTA_Air_Quality_Station