Added support for YINMIK YK-S03 Pool Monitoring #7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Jun 8, 2024
src/devices/tuya.ts
Outdated
| @@ -8712,6 +8712,76 @@ const definitions: Definition[] = [ | |||
| ], | |||
| }, | |||
| }, | |||
| { | |||
| fingerprint: tuya.fingerprint('TS0601', ['_TZE200_d9mzkhoq']), | |||
There was a problem hiding this comment.
I propose to merge this definition with BLE-YL01 (add the missing features there, probably they are exactly the same devices). For the correct detection, use tuya.whitelabel (search in this file for examples)
There was a problem hiding this comment.
What about the image? They looks a bit different.
There was a problem hiding this comment.
It will show in the UI with the props defined in the whitelabel, including the picture.
There was a problem hiding this comment.
I have merged the definition now, and added some whitelabels, as how I understod it works.
Is it okay now?
Fixed the value of free_chlorine to correct format.
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add support for YINMIK YK-S03 Smart pH and Chlorine Tester for Swimming Pool
https://www.amazon.com/YINMIK-Chlorine-Swimming-Salinity-Inground/dp/B0C2T8YLYW
It look like the same device as BLE-YL01, but some params might be a bit different.
Koenkk/zigbee2mqtt#18704
Image added in this PR Koenkk/zigbee2mqtt.io#2796