feat: Advertise 153-500 mireds for IKEA LED1624G9 #6640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbschenkel
force-pushed
the
LED1624G9_extend_temp_range
branch
from
aec9380 to
0b33e7c
Compare
This light is pure RGB, it does not contain white LEDs and it only supports XY, not color temperature. The latter is emulated by Z2M via a conversion to XY. The color temperature range advertised by this light is the same one as other IKEA lights, which typically have LEDs supporting the 2200-4000K range — but that does not make sense given that all temperatures are simulated, and the current temperature->XY conversion code accepts any value, including out of this range, if it is submitted via MQTT. Given the above, this commit changes the avertised range of this light to 2000-6500K. This has the benefit of making the whole range available in the UI of Home Assistant (compared to only via manual service calls).
lbschenkel
force-pushed
the
LED1624G9_extend_temp_range
branch
from
0b33e7c to
7c169cd
Compare
lbschenkel
added a commit
to lbschenkel/zigbee-herdsman-converters
that referenced
this pull request
Dec 6, 2023
LED1923R5/LED1925G6 lights seem to be pure RGB without white LEDs. After a lot of experimentation involving dozens of different color temperature values, and trying to set the same color via XY values, it was not possible to see the slightest shift in color. It looks like the light is actually working in XY mode all the time, and the firmware is simply converting color temperatures into XY internally. This makes this light similar to the older LED1624G9, except that the firmware of this newer one emulates the color temperature functionality, while the older one doesn't. Since the color temperature functionality is actually emulated by the firmware, this commit changes it to use the Z2M emulation implementation. This allows expanding the advertised color temperature range to 2000-6500K, an improvement over the firmware implementation which artificially clamps the values to the 2200K-4000K range. See: Koenkk#6640
lbschenkel
added a commit
to lbschenkel/zigbee-herdsman-converters
that referenced
this pull request
Dec 6, 2023
LED1923R5/LED1925G6 lights seem to be pure RGB without white LEDs. After a lot of experimentation involving dozens of different color temperature values, and trying to set the same color via XY values, it was not possible to see the slightest shift in color. It looks like the light is actually working in XY mode all the time, and the firmware is simply converting color temperatures into XY internally. This makes this light similar to the older LED1624G9, except that the firmware of this newer one emulates the color temperature functionality, while the older one doesn't. Since the color temperature functionality is actually emulated by the firmware, this commit changes it to use the Z2M emulation implementation. This allows expanding the advertised color temperature range to 2000-6500K, an improvement over the firmware implementation which artificially clamps the values to the 2200K-4000K range. See: Koenkk#6640
lbschenkel
added a commit
to lbschenkel/zigbee-herdsman-converters
that referenced
this pull request
Dec 6, 2023
LED1923R5/LED1925G6 lights seem to be pure RGB without white LEDs. After a lot of experimentation involving dozens of different color temperature values, and trying to set the same color via XY values, it was not possible to see the slightest shift in color. It looks like the light is actually working in XY mode all the time, and the firmware is simply converting color temperatures into XY internally. This makes this light similar to the older LED1624G9, except that the firmware of this newer one emulates the color temperature functionality, while the older one doesn't. Since the color temperature functionality is actually emulated by the firmware, this commit changes it to use the Z2M emulation implementation. This allows expanding the advertised color temperature range to 2000-6500K, an improvement over the firmware implementation which artificially clamps the values to the 2200K-4000K range. See: Koenkk#6640
lbschenkel
added a commit
to lbschenkel/zigbee-herdsman-converters
that referenced
this pull request
Dec 6, 2023
LED1923R5/LED1925G6 lights seem to be pure RGB without white LEDs. After a lot of experimentation involving dozens of different color temperature values, and trying to set the same color via XY values, it was not possible to see the slightest shift in color. It looks like the light is actually working in XY mode all the time, and the firmware is simply converting color temperatures into XY internally. This makes this light similar to the older LED1624G9, except that the firmware of this newer one emulates the color temperature functionality, while the older one doesn't. Since the color temperature functionality is actually emulated by the firmware, this commit changes it to use the Z2M emulation implementation. This allows expanding the advertised color temperature range to 2000-6500K, an improvement over the firmware implementation which artificially clamps the values to the 2200K-4000K range. See: Koenkk#6640
|
Thanks! |
Koenkk
pushed a commit
that referenced
this pull request
Dec 6, 2023
…0 mireds (#6642) LED1923R5/LED1925G6 lights seem to be pure RGB without white LEDs. After a lot of experimentation involving dozens of different color temperature values, and trying to set the same color via XY values, it was not possible to see the slightest shift in color. It looks like the light is actually working in XY mode all the time, and the firmware is simply converting color temperatures into XY internally. This makes this light similar to the older LED1624G9, except that the firmware of this newer one emulates the color temperature functionality, while the older one doesn't. Since the color temperature functionality is actually emulated by the firmware, this commit changes it to use the Z2M emulation implementation. This allows expanding the advertised color temperature range to 2000-6500K, an improvement over the firmware implementation which artificially clamps the values to the 2200K-4000K range. See: #6640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This light is pure RGB, it does not contain white LEDs and it only supports XY, not color temperature. The latter is emulated by Z2M via a conversion to XY. The color temperature range advertised by this light is the same one as other IKEA lights, which typically have LEDs supporting the 2200-4000K range — but that does not make sense given that all temperatures are simulated, and the current temperature->XY conversion code accepts any value, including out of this range, if it is submitted via MQTT.
Given the above, this commit changes the avertised range of this light to 2000-6500K. This has the benefit of making the whole range available in the UI of Home Assistant (compared to only via manual service calls).