Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TS0601_din_1 and add Sunricher SR-ZG9101SAC-HP-SWITCH-B fingerprint #6623

Merged
merged 7 commits into from
Dec 6, 2023

Conversation

dduransseau
Copy link
Contributor

  • Add reactive power, energy fields to Tuya TS0601_din_1
  • Correct Zemismart brand for SPM01-D2TZ (manufactured by bituo-technik)
  • Add Sunricher SR-ZG9101SAC-HP-SWITCH-B/ Vesternet VES-ZB-SWI-015 firmware fingerprint

Relative to previous PR #6607

@Koenkk
Copy link
Owner

Koenkk commented Dec 5, 2023

@martyn-vesternet could you check the changes to vesternet.ts?

[102, 'produced_energy', tuya.valueConverter.divideBy100],
[103, 'power', tuya.valueConverter.raw],
[105, 'ac_frequency', tuya.valueConverter.divideBy100],
[109, 'energy_reactive', tuya.valueConverter.divideBy100], // reactive energy in VArh
[110, 'power_reactive', tuya.valueConverter.raw], // reactive power
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the exposes accordingly.

@martyn-vesternet
Copy link
Contributor

@dduransseau I would suggest creating your own dedicated device in the Sunricher file to suit that particular firmware version.

You'll want to make sure that the configuration for the Vesternet version works correctly with your version, especially as there is a pending PR that accounts for differing behaviours between versions 2.5.3_r2 and 2.9.2_r3 (measurements are on different endpoints).

@dduransseau
Copy link
Contributor Author

@martyn-vesternet done.
I see your point and seems a good thing that there is a new endpoint for measurement. On my device I see measure on each channel endpoint but values are exactly the same which should not be the case at least for power. Having a dedicated endpoint for shared value would make more sense.

@Koenkk
Copy link
Owner

Koenkk commented Dec 6, 2023

@martyn-vesternet ready for merge?

@martyn-vesternet
Copy link
Contributor

@Koenkk for this one yes, I think the changes to vesternet.ts were removed so should be OK.

@Koenkk Koenkk merged commit ddf7dcf into Koenkk:master Dec 6, 2023
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 6, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants