-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Use modern macro for name of class #126
base: main
Are you sure you want to change the base?
Conversation
When preparing for the future with ITK by setting ITK_FUTURE_LEGACY_REMOVE:BOOL=ON ITK_LEGACY_REMOVEBOOL=ON The future preferred macro should be used │ - itkTypeMacro │ + itkOverrideGetNameOfClassMacro
@dzenanz This is part of an effort to create a v5.4.2.1 release that allows Slicer to build with ITK_LEGACY_REMOVE and ITK_FUTURE_LEGACY_REMOVE turned on. It is an intermediate refactoring that is upstream compatible but allows Slicer to catch up more slowly. |
@dzenanz Part of the future updates needed to build Slicer with future code recommendationsl |
bb87429
to
53b8a4f
Compare
53b8a4f
to
9fdec0a
Compare
This sounds like WASM part needs to be updated to use a newer base image:
|
Is |
Yes, it was added in Dec 2023. |
It is there already in v5.4.0: |
I will rebase, follow-up. |
When preparing for the future with ITK by setting
ITK_FUTURE_LEGACY_REMOVE:BOOL=ON
ITK_LEGACY_REMOVEBOOL=ON
The future preferred macro should be used
│ - itkTypeMacro
│ + itkOverrideGetNameOfClassMacro