Update nvidia keys #1632
Open
Update nvidia keys #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was triggered if no tracks were created on the first frame.
…es-core-deref Avoid dereferencing an end iterator in track_features_core
If not, there's at least one issue due to threading, namely that the call to merge_tracks can ultimately call erase on simple_track_set_implementation::data_, which can cause the call to simple_track_set_implementation::tracks, which copies data_ and is indirectly made by match_tracks, to copy data_ while elements are actively being removed from it. This manifests as empty shared_ptrs in the return value of tracks that are dereferenced in track_set_implementation::active_tracks to cause a segfault. Commit 17c7936 appears to have broken this.
…exhaustive-threading Fix race condition in close_loops_exhaustive
|
@mleotta Please review. Without this, the docker does not build. |
mleotta
approved these changes
Jun 10, 2022
danlipsa
force-pushed
the
update-nvidia-keys
branch
from
930a90e to
ad0be47
Compare
danlipsa
force-pushed
the
update-nvidia-keys
branch
from
ad0be47 to
0c2ace6
Compare
|
@mleotta I based this change on the release branch and updated the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.